[llvm-commits] [llvm] r63843 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/2009-02-04-sext-i64-gep.ll

[Chris Lattner]

Author: lattner
Date: Thu Feb  5 00:55:21 2009
New Revision: 63843

URL: http://llvm.org/viewvc/llvm-project?rev=63843&view=rev
Log:
if we have a large GEP offset on a 32-bit or other target, make
sure to print the value properly sext'd to the right pointer size.
This fixes PR3481.

Added:
    llvm/trunk/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll
Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=63843&r1=63842&r2=63843&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Thu Feb  5 00:55:21 2009
@@ -815,6 +815,12 @@
       SmallVector<Value*, 8> idxVec(CE->op_begin()+1, CE->op_end());
       if (int64_t Offset = TD->getIndexedOffset(ptrVal->getType(), &idxVec[0],
                                                 idxVec.size())) {
+        // Truncate/sext the offset to the pointer size.
+        if (TD->getPointerSizeInBits() != 64) {
+          int SExtAmount = 64-TD->getPointerSizeInBits();
+          Offset = (Offset << SExtAmount) >> SExtAmount;
+        }
+        
         if (Offset)
           O << '(';
         EmitConstantValueOnly(ptrVal);

Added: llvm/trunk/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll?rev=63843&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll (added)
+++ llvm/trunk/test/CodeGen/X86/2009-02-04-sext-i64-gep.ll Thu Feb  5 00:55:21 2009
@@ -0,0 +1,9 @@
+; RUN: llvm-as < %s | llc | grep { - 92}
+; PR3481
+; The offset should print as -92, not +17179869092
+
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32"
+target triple = "i386-pc-linux-gnu"
+ at p = common global [10 x i32] zeroinitializer, align 4          ; <[10 x i32]*>
+ at g = global [1 x i32*] [ i32* bitcast (i8* getelementptr (i8* bitcast
+([10 x i32]* @p to i8*), i64 17179869092) to i32*) ], align 4