[llvm-commits] [llvm] r63593 - in /llvm/trunk/lib/CodeGen/SelectionDAG: SelectionDAGBuild.cpp SelectionDAGISel.cpp

Evan Cheng evan.cheng at apple.com
Mon Feb 2 17:56:41 PST 2009


On Feb 2, 2009, at 5:51 PM, Dale Johannesen wrote:

>
> On Feb 2, 2009, at 5:33 PMPST, Bill Wendling wrote:
>
>> Author: void
>> Date: Mon Feb  2 19:33:28 2009
>> New Revision: 63593
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=63593&view=rev
>> Log:
>> Explicitly pass in the "unknown" debug location. This is probably not
>> correct. We need more infrastructure before we can get the DebugLoc
>> info for
>> these instructions.
>>
>> Modified:
>>   llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>
> I don't think we need this for PHIs, they don't survive to the output.

They can become copies which are not always coalesced away.

Evan

>
>
>>   llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
>
> The "current" debug info loc, based on reading the stoppoint nodes as
> they go by,  is available here as SDL->getCurDebugLoc().
> Not sure how accurate that will be for landing pads but it's probably
> better than nothing.
>
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp?rev=63593&r1=63592&r2=63593&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>> (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp Mon
>> Feb  2 19:33:28 2009
>> @@ -333,7 +333,8 @@
>>        unsigned NumRegisters = TLI.getNumRegisters(VT);
>>        const TargetInstrInfo *TII = MF->getTarget().getInstrInfo();
>>        for (unsigned i = 0; i != NumRegisters; ++i)
>> -          BuildMI(MBB, TII->get(TargetInstrInfo::PHI), PHIReg+i);
>> +          BuildMI(MBB, DebugLoc::getUnknownLoc(),
>> +                  TII->get(TargetInstrInfo::PHI), PHIReg + i);
>>        PHIReg += NumRegisters;
>>      }
>>    }
>>
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=63593&r1=63592&r2=63593&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
>> (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Mon
>> Feb  2 19:33:28 2009
>> @@ -743,7 +743,7 @@
>>      unsigned LabelID = MMI->addLandingPad(BB);
>>
>>      const TargetInstrDesc &II = TII.get(TargetInstrInfo::EH_LABEL);
>> -      BuildMI(BB, II).addImm(LabelID);
>> +      BuildMI(BB, DebugLoc::getUnknownLoc(), II).addImm(LabelID);
>>
>>      // Mark exception register as live in.
>>      unsigned Reg = TLI.getExceptionAddressRegister();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list