[llvm-commits] [llvm] r63593 - in /llvm/trunk/lib/CodeGen/SelectionDAG: SelectionDAGBuild.cpp SelectionDAGISel.cpp

[Evan Cheng]

On Feb 2, 2009, at 5:33 PM, Bill Wendling wrote:

> Author: void
> Date: Mon Feb  2 19:33:28 2009
> New Revision: 63593
>
> URL: http://llvm.org/viewvc/llvm-project?rev=63593&view=rev
> Log:
> Explicitly pass in the "unknown" debug location. This is probably not
> correct. We need more infrastructure before we can get the DebugLoc  
> info for
> these instructions.
>
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
>    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp?rev=63593&r1=63592&r2=63593&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp  
> (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp Mon  
> Feb  2 19:33:28 2009
> @@ -333,7 +333,8 @@
>         unsigned NumRegisters = TLI.getNumRegisters(VT);
>         const TargetInstrInfo *TII = MF->getTarget().getInstrInfo();
>         for (unsigned i = 0; i != NumRegisters; ++i)
> -          BuildMI(MBB, TII->get(TargetInstrInfo::PHI), PHIReg+i);
> +          BuildMI(MBB, DebugLoc::getUnknownLoc(),
> +                  TII->get(TargetInstrInfo::PHI), PHIReg + i);
>         PHIReg += NumRegisters;

Perhaps these should have the same location as the first instruction  
in the basic block? If there are no instructions, it has to traverse  
up the predecessor chain.

Evan
>
>       }
>     }
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp?rev=63593&r1=63592&r2=63593&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp  
> (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp Mon  
> Feb  2 19:33:28 2009
> @@ -743,7 +743,7 @@
>       unsigned LabelID = MMI->addLandingPad(BB);
>
>       const TargetInstrDesc &II = TII.get(TargetInstrInfo::EH_LABEL);
> -      BuildMI(BB, II).addImm(LabelID);
> +      BuildMI(BB, DebugLoc::getUnknownLoc(), II).addImm(LabelID);
>
>       // Mark exception register as live in.
>       unsigned Reg = TLI.getExceptionAddressRegister();
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits