[llvm-commits] [llvm] r63370 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Analysis/BasicAliasAnalysis.cpp lib/CodeGen/ScheduleDAGInstrs.cpp

[Chris Lattner]

On Jan 29, 2009, at 6:49 PM, Dan Gohman wrote:
> Author: djg
> Date: Thu Jan 29 20:49:14 2009
> New Revision: 63370
>
> URL: http://llvm.org/viewvc/llvm-project?rev=63370&view=rev
> Log:
> Fix a post-RA scheduling dependency bug.

Hi Dan,

> +/// isIdentifiedObject - Return true if this pointer refers to a  
> distinct and
> +/// identifiable object.
> +///
> +bool isIdentifiedObject(const Value *V);

the comment in the .cpp file is significantly more useful than this,  
please copy it.

> +++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Thu Jan 29  
> 20:49:14 2009
> @@ -80,7 +80,7 @@
> ///    ByVal and NoAlias Arguments
> ///    NoAlias returns
> ///
> -static bool isIdentifiedObject(const Value *V) {
> +bool llvm::isIdentifiedObject(const Value *V) {

Please move this function into AliasAnalysis.cpp.

-Chris