[llvm-commits] [llvm] r63359 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAG.h lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp

[Chris Lattner]

On Jan 30, 2009, at 10:00 AM, Dale Johannesen wrote:

>
> On Jan 29, 2009, at 6:22 PMPST, Chris Lattner wrote:
>
>> On Jan 29, 2009, at 5:47 PM, Dale Johannesen wrote:
>>>> Thanks Dale!  One issue: instead of "getCurDebugLoc()" and friends
>>>> being on the SelectionDAG, please move them to do the dag builder
>>>> class.
>>>
>>> What do you mean?  I had it in SelectionDAGLowering originally,  
>>> which
>>> looked right to me, but it looked like there wasn't an easy way to
>>> get
>>> there from everywhere that was calling getNode.
>>
>> What places needed it other than SDBuilder?
>
> I'm thinking of the target-dependent parts of that like
> TargetLowering::LowerCallTo; there are several in the various target
> files.   Doesn't seem to be an easy way to get the
> SelectionDAGLowering object from there.   (btw, I asked Evan's opinion
> of where this should go before doing it this way; he didn't care.)

While annoying, I think it would be better to pass the location to use  
into LowerCallTo.  Putting it in SelectionDAG makes it so that non- 
builder clients could accidentally use it instead of using a proper  
source location.

-Chris