[llvm-commits] [llvm-gcc-4.2] r63076 - in /llvm-gcc-4.2/trunk/gcc: config/i386/llvm-i386-target.h llvm-backend.cpp

[Dan Gohman]

In GCC there are comments about using the red zone on i386 in
contexts where measures have been taken to guarantee that
it is safe.

Dan

On Jan 28, 2009, at 10:33 PM, Evan Cheng wrote:

> Hi Dan,
>
> This seems to pass --disable-red-zone when target is i386. Obviously
> it causes no harm but it seems a bit strange. Is it intended?
>
> Evan
>
> On Jan 26, 2009, at 4:42 PM, Dan Gohman wrote:
>
>> Author: djg
>> Date: Mon Jan 26 18:42:11 2009
>> New Revision: 63076
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=63076&view=rev
>> Log:
>> Translate GCC's -mno-red-zone option to LLVM's -disable-red-zone
>> option.
>>
>> Modified:
>>   llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386-target.h
>>   llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp
>>
>> Modified: llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386-target.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386-target.h?rev=63076&r1=63075&r2=63076&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386-target.h (original)
>> +++ llvm-gcc-4.2/trunk/gcc/config/i386/llvm-i386-target.h Mon Jan 26
>> 18:42:11 2009
>> @@ -89,6 +89,10 @@
>>    }                                                           \
>>  }
>>
>> +#define LLVM_SET_ARCH_OPTIONS(argvec)                           \
>> +  if (TARGET_NO_RED_ZONE)                                       \
>> +    argvec.push_back("--disable-red-zone");
>> +
>> #ifdef LLVM_ABI_H
>>
>> /* On x86-32 objects containing SSE vectors are 16 byte aligned,
>> everything
>>
>> Modified: llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp?rev=63076&r1=63075&r2=63076&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp (original)
>> +++ llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp Mon Jan 26 18:42:11 2009
>> @@ -131,6 +131,9 @@
>>
>>  // Allow targets to specify PIC options and other stuff to the
>> corresponding
>>  // LLVM backends.
>> +#ifdef LLVM_SET_ARCH_OPTIONS
>> +  LLVM_SET_ARCH_OPTIONS(Args);
>> +#endif
>> #ifdef LLVM_SET_TARGET_OPTIONS
>>  LLVM_SET_TARGET_OPTIONS(Args);
>> #endif
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits