[llvm-commits] [llvm] r63155 - in /llvm/trunk/include/llvm/CodeGen: MachineInstr.h SelectionDAGNodes.h

[Dale Johannesen]

Author: johannes
Date: Tue Jan 27 17:32:10 2009
New Revision: 63155

URL: http://llvm.org/viewvc/llvm-project?rev=63155&view=rev
Log:
Embalm my ideas of how things should work.  Not that
anyone will pay attention.


Modified:
    llvm/trunk/include/llvm/CodeGen/MachineInstr.h
    llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h

Modified: llvm/trunk/include/llvm/CodeGen/MachineInstr.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineInstr.h?rev=63155&r1=63154&r2=63155&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineInstr.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineInstr.h Tue Jan 27 17:32:10 2009
@@ -313,6 +313,7 @@
   void setDesc(const TargetInstrDesc &tid) { TID = &tid; }
 
   /// setDebugLoc - Replace current source information with new such.
+  /// Avoid using this, the constructor argument is preferable.
   ///
   void setDebugLoc(const DebugLoc dl) { debugLoc = dl; }
 

Modified: llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h?rev=63155&r1=63154&r2=63155&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h (original)
+++ llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h Tue Jan 27 17:32:10 2009
@@ -1154,7 +1154,8 @@
   /// getDebugLoc - Return the source location info.
   const DebugLoc getDebugLoc() const { return debugLoc; }
 
-  /// setDebugLoc - Set source location info.
+  /// setDebugLoc - Set source location info.  Try to avoid this, putting
+  /// it in the constructor is preferable.
   void setDebugLoc(const DebugLoc dl) { debugLoc = dl; }
 
   /// use_iterator - This class provides iterator support for SDUse