[llvm-commits] [llvm] r63136 - /llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h

[Chris Lattner]

On Jan 27, 2009, at 1:41 PM, Dale Johannesen wrote:
> Author: johannes
> Date: Tue Jan 27 15:41:04 2009
> New Revision: 63136
>
> URL: http://llvm.org/viewvc/llvm-project?rev=63136&view=rev
> Log:
> Add DebugLoc field and simple accessors.

Thanks Dale!

> +  /// is that they will replace the above two over time, and  
> eventually
> +  /// the ones above can be removed.
> +  SDNode(unsigned Opc, SDVTList VTs, const SDValue *Ops, unsigned  
> NumOps,
> +         DebugLoc sl)

Do you think it would be reasonable to pass DebugLoc immediately after  
Opc?  Since all ctor/get methods will eventually convert to passing a  
location, it would be nice for them to be consistent.  If it is at the  
end of the list then we have get(opcode, ...random stuff depending on  
the accessor... , loc).  It would be nicer to have get(opcode,  
loc, ... random stuff depending on the accessor...)

-Chris