[llvm-commits] [llvm-gcc-4.2] r63109 - in /llvm-gcc-4.2/trunk/gcc: gimplify.c llvm-backend.cpp llvm-convert.cpp tree.h

[Stuart Hastings]

On Jan 27, 2009, at 10:48 AM, Duncan Sands wrote:

>> Restoring DECL_LLVM_PRIVATE (rev 62850) with a patch to fix some  
>> ObjC DejaGNU regressions.
>
> What was the fix and what was regressing?

In llvm-backend.cpp, I added the "CODE_CONTAINS_STRUCT" voodoo around  
line 1085:

+  if (CODE_CONTAINS_STRUCT (TREE_CODE (decl), TS_DECL_WITH_VIS)
+      && DECL_LLVM_PRIVATE(decl)) {

There were at least three ICEs in the ObjC DejaGNU tests:

FAIL: objc.dg/const-cfstring-6.m (test for excess errors)
FAIL: objc.dg/pubtypes-id-test.m (test for excess errors)
FAIL: obj-c++.dg/const-cfstring-6.mm (test for excess errors)

While the patch doesn't make all the tests pass, at least the ICE-ing  
is gone.  (On my dev machine, the const-cfstring-6.{m,mm} tests now  
fail with a linker error.)

> Thanks,

You're very welcome,

stuart