[llvm-commits] [llvm] r62476 - /llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

[Chris Lattner]

Author: lattner
Date: Sun Jan 18 18:36:37 2009
New Revision: 62476

URL: http://llvm.org/viewvc/llvm-project?rev=62476&view=rev
Log:
Fix some problems in SpeculativelyExecuteBB.  Basically,
because of dead code, a phi could use the speculated instruction
that was not in "BB2".  Make this check explicit and tighten up 
some other corners.  This fixes PR3292.  No testcase becauase this
depends entirely on visitation order of blocks and requires a 
sequence of 8 passes to repro.


Modified:
    llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp

Modified: llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp?rev=62476&r1=62475&r2=62476&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp Sun Jan 18 18:36:37 2009
@@ -984,6 +984,12 @@
       return false;
     break;   // These are all cheap and non-trapping instructions.
   }
+  
+  // If the instruction is obviously dead, don't try to predicate it.
+  if (I->use_empty()) {
+    I->eraseFromParent();
+    return true;
+  }
 
   // Can we speculatively execute the instruction? And what is the value 
   // if the condition is false? Consider the phi uses, if the incoming value
@@ -992,20 +998,25 @@
   BasicBlock *BIParent = BI->getParent();
   SmallVector<PHINode*, 4> PHIUses;
   Value *FalseV = NULL;
+  
+  BasicBlock *BB2 = BB1->getTerminator()->getSuccessor(0);
   for (Value::use_iterator UI = I->use_begin(), E = I->use_end();
        UI != E; ++UI) {
+    // Ignore any user that is not a PHI node in BB2.  These can only occur in
+    // unreachable blocks, because they would not be dominated by the instr.
     PHINode *PN = dyn_cast<PHINode>(UI);
-    if (!PN)
-      continue;
+    if (!PN || PN->getParent() != BB2)
+      return false;
     PHIUses.push_back(PN);
+    
     Value *PHIV = PN->getIncomingValueForBlock(BIParent);
     if (!FalseV)
       FalseV = PHIV;
     else if (FalseV != PHIV)
-      return false;  // Don't know the value when condition is false.
+      return false;  // Inconsistent value when condition is false.
   }
-  if (!FalseV)  // Can this happen?
-    return false;
+  
+  assert(FalseV && "Must have at least one user, and it must be a PHI");
 
   // Do not hoist the instruction if any of its operands are defined but not
   // used in this BB. The transformation will prevent the operand from