[llvm-commits] [llvm] r62286 - in /llvm/trunk: include/llvm/CodeGen/DwarfWriter.h lib/CodeGen/AsmPrinter/DwarfWriter.cpp lib/CodeGen/SelectionDAG/FastISel.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp test/DebugInfo/2009-01-15-dbg_declare.ll

[Chris Lattner]

On Jan 16, 2009, at 11:22 AM, Evan Cheng wrote:
>> Which is pretty much what you have to do in any case.  DIDescriptor  
>> shouldn't add over head here as long as it isn't "new"d.
>
> Ok. But it's still seems somewhat awkward to me. Wouldn't a static  
> method that does this check seem cleaner to you?
>
Not really.  This is the fundamental design of the new Analysis/ 
DebugInfo.h stuff.  It is important to handle the version check  
consistently with the rest of the methods.  Are you seen an actual  
performance issue?

-Chris