[llvm-commits] [llvm] r62244 - in /llvm/trunk: lib/Transforms/Scalar/SCCP.cpp test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll

[Chris Lattner]

Author: lattner
Date: Wed Jan 14 15:01:16 2009
New Revision: 62244

URL: http://llvm.org/viewvc/llvm-project?rev=62244&view=rev
Log:
Fix PR3325, a miscompilation of invokes by IPSCCP.  Patch by Jay Foad!

Added:
    llvm/trunk/test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/SCCP.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/SCCP.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SCCP.cpp?rev=62244&r1=62243&r2=62244&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/SCCP.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/SCCP.cpp Wed Jan 14 15:01:16 2009
@@ -1749,8 +1749,7 @@
       } else {
         for (BasicBlock::iterator BI = BB->begin(), E = BB->end(); BI != E; ) {
           Instruction *Inst = BI++;
-          if (Inst->getType() == Type::VoidTy ||
-              isa<TerminatorInst>(Inst))
+          if (Inst->getType() == Type::VoidTy)
             continue;
           
           LatticeVal &IV = Values[Inst];
@@ -1766,7 +1765,7 @@
           Inst->replaceAllUsesWith(Const);
           
           // Delete the instruction.
-          if (!isa<CallInst>(Inst))
+          if (!isa<CallInst>(Inst) && !isa<TerminatorInst>(Inst))
             Inst->eraseFromParent();
 
           // Hey, we just changed something!

Added: llvm/trunk/test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll?rev=62244&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll (added)
+++ llvm/trunk/test/Transforms/SCCP/2009-01-14-IPSCCP-Invoke.ll Wed Jan 14 15:01:16 2009
@@ -0,0 +1,28 @@
+; RUN: llvm-as < %s | opt -ipsccp | llvm-dis | grep {ret i32 42}
+; RUN: llvm-as < %s | opt -ipsccp | llvm-dis | grep {ret i32 undef}
+; PR3325
+
+define i32 @main() {
+	%tmp1 = invoke i32 @f()
+			to label %UnifiedReturnBlock unwind label %lpad
+
+lpad:
+	unreachable
+
+UnifiedReturnBlock:
+	ret i32 %tmp1
+}
+
+define internal i32 @f() {
+       ret i32 42
+}
+
+declare i8* @__cxa_begin_catch(i8*) nounwind
+
+declare i8* @llvm.eh.exception() nounwind
+
+declare i32 @llvm.eh.selector.i32(i8*, i8*, ...) nounwind
+
+declare void @__cxa_end_catch()
+
+declare i32 @__gxx_personality_v0(...)