[llvm-commits] [llvm] r62125 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp

[Chris Lattner]

On Jan 12, 2009, at 4:20 PM, Devang Patel wrote:

> Author: dpatel
> Date: Mon Jan 12 18:20:51 2009
> New Revision: 62125
>
> URL: http://llvm.org/viewvc/llvm-project?rev=62125&view=rev
> Log:
> Start using DebugInfo API to emit debug info.

Ok, nice progress!

>
>     if (!Slot) {
>       // FIXME - breaks down when the context is an inlined function.
>       DIDescriptor ParentDesc;
> -      DIDescriptor *DB = new DIBlock(V);
> +      DIDescriptor *DB = new DIDescriptor(V);

Why are you 'new'ing these things?  The descriptors are meant to be  
very light-weight objects that are just handles on existing global  
variable descriptors.  There should be no reason to new them, just  
create (through various methods on DIFactory) new global variable  
descriptors themselves.

-Chris