[llvm-commits] [llvm] r61765 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h lib/CodeGen/AsmPrinter/DwarfWriter.cpp lib/Target/TargetAsmInfo.cpp lib/Target/X86/X86TargetAsmInfo.cpp

Bill Wendling isanbard at gmail.com
Mon Jan 5 14:53:47 PST 2009


Author: void
Date: Mon Jan  5 16:53:45 2009
New Revision: 61765

URL: http://llvm.org/viewvc/llvm-project?rev=61765&view=rev
Log:
Revert r61415 and r61484. Duncan was correct that these weren't needed.

Modified:
    llvm/trunk/include/llvm/Target/TargetAsmInfo.h
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp
    llvm/trunk/lib/Target/TargetAsmInfo.cpp
    llvm/trunk/lib/Target/X86/X86TargetAsmInfo.cpp

Modified: llvm/trunk/include/llvm/Target/TargetAsmInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetAsmInfo.h?rev=61765&r1=61764&r2=61765&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Target/TargetAsmInfo.h (original)
+++ llvm/trunk/include/llvm/Target/TargetAsmInfo.h Mon Jan  5 16:53:45 2009
@@ -448,20 +448,10 @@
     ///
     bool DwarfRequiresFrameSection; // Defaults to true.
 
-    /// FDEEncodingRequiresSData4 - If set, the FDE Encoding in the EH section
-    /// includes DW_EH_PE_sdata4.
-    /// 
-    bool FDEEncodingRequiresSData4;         // Defaults to true
-
     /// NonLocalEHFrameLabel - If set, the EH_frame label needs to be non-local.
     /// 
     bool NonLocalEHFrameLabel;              // Defaults to false.
 
-    /// Force32BitFDEReference - Force the FDE initial location and address
-    /// range to be 32-bit sized.
-    ///
-    bool Force32BitFDEReference;            // Defaults to true.
-
     /// GlobalEHDirective - This is the directive used to make exception frame
     /// tables globally visible.
     ///
@@ -828,15 +818,9 @@
     bool doesDwarfRequireFrameSection() const {
       return DwarfRequiresFrameSection;
     }
-    bool doesFDEEncodingRequireSData4() const {
-      return FDEEncodingRequiresSData4;
-    }
     bool doesRequireNonLocalEHFrameLabel() const {
       return NonLocalEHFrameLabel;
     }
-    bool doesRequire32BitFDEReference() const {
-      return Force32BitFDEReference;
-    }
     const char *getGlobalEHDirective() const {
       return GlobalEHDirective;
     }

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp?rev=61765&r1=61764&r2=61765&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfWriter.cpp Mon Jan  5 16:53:45 2009
@@ -3410,24 +3410,14 @@
       Asm->EmitInt8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);
       Asm->EOL("LSDA Encoding (pcrel sdata4)");
 
-      if (TAI->doesFDEEncodingRequireSData4()) {
-        Asm->EmitInt8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);
-        Asm->EOL("FDE Encoding (pcrel sdata4)");
-      } else {
-        Asm->EmitInt8(DW_EH_PE_pcrel);
-        Asm->EOL("FDE Encoding (pcrel)");
-      }
+      Asm->EmitInt8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);
+      Asm->EOL("FDE Encoding (pcrel sdata4)");
    } else {
       Asm->EmitULEB128Bytes(1);
       Asm->EOL("Augmentation Size");
 
-      if (TAI->doesFDEEncodingRequireSData4()) {
-        Asm->EmitInt8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);
-        Asm->EOL("FDE Encoding (pcrel sdata4)");
-      } else {
-        Asm->EmitInt8(DW_EH_PE_pcrel);
-        Asm->EOL("FDE Encoding (pcrel)");
-      }
+      Asm->EmitInt8(DW_EH_PE_pcrel | DW_EH_PE_sdata4);
+      Asm->EOL("FDE Encoding (pcrel sdata4)");
     }
 
     // Indicate locations of general callee saved registers in frame.
@@ -3508,12 +3498,10 @@
 
       Asm->EOL("FDE CIE offset");
 
-      EmitReference("eh_func_begin", EHFrameInfo.Number, true, 
-                    TAI->doesRequire32BitFDEReference());
+      EmitReference("eh_func_begin", EHFrameInfo.Number, true);
       Asm->EOL("FDE initial location");
       EmitDifference("eh_func_end", EHFrameInfo.Number,
-                     "eh_func_begin", EHFrameInfo.Number,
-                     TAI->doesRequire32BitFDEReference());
+                     "eh_func_begin", EHFrameInfo.Number);
       Asm->EOL("FDE address range");
 
       // If there is a personality and landing pads then point to the language

Modified: llvm/trunk/lib/Target/TargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetAsmInfo.cpp?rev=61765&r1=61764&r2=61765&view=diff

==============================================================================
--- llvm/trunk/lib/Target/TargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/TargetAsmInfo.cpp Mon Jan  5 16:53:45 2009
@@ -99,9 +99,7 @@
   SupportsDebugInformation = false;
   SupportsExceptionHandling = false;
   DwarfRequiresFrameSection = true;
-  FDEEncodingRequiresSData4 = true;
   NonLocalEHFrameLabel = false;
-  Force32BitFDEReference = true;
   GlobalEHDirective = 0;
   SupportsWeakOmittedEHFrame = true;
   DwarfSectionOffsetDirective = 0;

Modified: llvm/trunk/lib/Target/X86/X86TargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetAsmInfo.cpp?rev=61765&r1=61764&r2=61765&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86TargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86TargetAsmInfo.cpp Mon Jan  5 16:53:45 2009
@@ -70,9 +70,7 @@
   COMMDirectiveTakesAlignment = (Subtarget->getDarwinVers() >= 9);
   HasDotTypeDotSizeDirective = false;
   HasSingleParameterDotFile = false;
-  FDEEncodingRequiresSData4 = false;
   NonLocalEHFrameLabel = true;
-  Force32BitFDEReference = false;
   if (TM.getRelocationModel() == Reloc::Static) {
     StaticCtorsSection = ".constructor";
     StaticDtorsSection = ".destructor";





More information about the llvm-commits mailing list