[llvm-commits] [PATCH] Teach IRBuilder about simplifying BinOp(Value, Constant)

[Chris Lattner]

On Jan 5, 2009, at 1:25 AM, Török Edwin wrote:
> I added back the Constant* functions in ConstantFolder/TargetFolder,
> since llvm-gcc is using them (called with constant* params, expecting
> constant* return).

Hi Edwin,

Please don't put the large SimplifyBinOp/findBinOp functions inline  
into ConstantFolder.h.

Also, I think it is somewhat strange to call ConstantFolder::CreateNot  
with non-constant operands.  Should this functionality be moved out of  
the ConstantFolder class into some new place?

finally, please follow the standard convention of putting the '{' on  
the previous line instead of on a new one.

-Chris