[llvm-commits] [llvm] r61558 - in /llvm/trunk: include/llvm/Assembly/ lib/AsmParser/ lib/VMCore/ test/Assembler/ test/Feature/ test/Integer/ test/Linker/ test/Transforms/GlobalOpt/ test/Verifier/ tools/bugpoint/ tools/llvm-as/

[Bill Wendling]

On Jan 3, 2009, at 5:26 PM, Chris Lattner wrote:

> On Jan 2, 2009, at 3:19 PM, Bill Wendling wrote:
>
>> On Jan 1, 2009, at 11:01 PM, Chris Lattner wrote:
>>> Author: lattner
>>> Date: Fri Jan  2 01:01:27 2009
>>> New Revision: 61558
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=61558&view=rev
>>> Log:
>>> Reimplement the old and horrible bison parser for .ll files with a
>>> nice
>>> and clean recursive descent parser.
>>>
>>
>> I'm getting another strange error when LLVM self-hosts:
>
> This is somewhat puzzling to me Bill, llvm-gcc doesn't even link in
> the .ll parser at all!  Are you sure it isn't a nearby patch?
>
I got more information in a follow-up to this email. It looks like  
llvm::PATypeHolder::get() was definied in llvmAsmParser.y. So when  
that file went away, the definition wasn't there anymore. This is  
probably a long-standing bug that wasn't ever found because of that.

I temporarily added a #include of Type.h to ELFWriter.cpp that should  
help this out (crosses fingers). Maybe it should be marked as  
"always_inline" instead?

-bw