[llvm-commits] Patch: Adding unit tests to LLVM

Dan Gohman gohman at apple.com
Mon Dec 22 13:03:26 PST 2008

On Dec 18, 2008, at 1:10 PM, Talin wrote:

> This patch adds a unit test framework to LLVM, along with a sample  
> unit test for DenseMap. I don't expect this patch to be accepted as- 
> is, this is mainly a trial balloon and proof of concept.

Hi Talin,

I think this looks useful. I'm contemplating a change to the
DenseMap class right now, actually, and I may try out your
patch to help test it :-).

> 3) I did not actually include the testing framework in the patch; It  
> will need to be checked in separately. There are two approaches to  
> this. One approach is to use the svn:external feature to create a  
> link to the googletest svn repository from the LLVM svn repository.  
> The other approach is to take a snapshot of googletest and check it  
> in to the LLVM repository.

I've found svn:externals to repositories on different servers
to be inconvenient. If the framework isn't inconveniently large,
I think it'd be best to take snapshots.

> The GoogleTest tar archive is here: http://code.google.com/p/googletest/downloads/list 
> . I've located it within the LLVM source tree in the location "third- 
> party/googletest".

My sense is that the "third-party" part is unnecessary, and it'd be
nicer to just have googletest at the top level, but I don't have a
strong opinion here.


More information about the llvm-commits mailing list