[llvm-commits] [llvm] r61250 - /llvm/trunk/lib/Target/X86/X86Instr64bit.td

[Dan Gohman]

On Dec 19, 2008, at 4:51 PM, Evan Cheng wrote:

>
> On Dec 19, 2008, at 10:25 AM, Dan Gohman wrote:
>
>> Author: djg
>> Date: Fri Dec 19 12:25:21 2008
>> New Revision: 61250
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=61250&view=rev
>> Log:
>> Move the patterns which have i8 immediates before the patterns
>> that have i32 immediates so that they get selected first. This
>> currently only matters in the JIT, as assemblers will
>> automatically use the smallest encoding.
>
>
> Ugh. We can't assume source order has anything to do with selection
> order. Perhaps we can add some kind of code to these PatLeaf's?

I briefly looked at some fancier ways of doing this, but didn't find
anything simple, and I wasn't looking to do anything complicated.
Tablegen uses stable_sort, so source order is effectively
used as a tie-breaker.

Dan