[llvm-commits] [llvm] r60857 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/add-with-overflow.ll

[Chris Lattner]

On Dec 10, 2008, at 2:36 PM, Bill Wendling wrote:

> Author: void
> Date: Wed Dec 10 16:36:00 2008
> New Revision: 60857
>
> URL: http://llvm.org/viewvc/llvm-project?rev=60857&view=rev
> Log:
> If ADD, SUB, or MUL have an overflow bit that's used, don't do  
> transformation on
> them. The DAG combiner expects that nodes that are transformed have  
> one value
> result.

Bill, I'm very confused about this.  The "ADD" node is defined to have  
two inputs and one output.  How could N->getNumValues() even be non  
1?  Are you somehow getting SADDO/UADDO into this code?  visitADD  
should only be called on an ADD node.  What am I missing?

-Chris