[llvm-commits] Functor Patch for Visual Studio and Documentation fix to update the Visual Studio page

[OvermindDL1]

On Sun, Dec 7, 2008 at 4:43 PM, Nick Lewycky <nicholas at mxc.ca> wrote:
> OvermindDL1 wrote:
>> Attached is first a patch to add a const qualifier on a functor so
>> Visual Studio 2005 will build (the standard says it should be there,
>> but is not strictly required by it, however it is required by VS2k5).
>
> That change looks right to me. Thanks for working on it.
>
>> Also included are fixes to update the GettingStartedVS.html page to
>> make it more up-to-date.
>>
>> Also included is a fix to GettingStarted.html to update the minimum
>> Visual Studio version required.
>
> +    <li>If CMake is installed then the most simple way is to just start
> the gui
>
> gui -> GUI
>
> +    compiling is complete</li>
>
> Add a full stop like the other bullet points have.
>
> +  (and please submit a patch if you do).  Earlier version of Visual Studio
>
> Pluralize version to versions.

Patch updated with the above changes and attached (also change from
"gui interface" to "CMake GUI" as it is more explicit).


On Sun, Dec 7, 2008 at 4:43 PM, Nick Lewycky <nicholas at mxc.ca> wrote:
> Do you have commit access?

No, I do not have any access beyond anonymous.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FunctorAndDocs1.patch
Type: application/octet-stream
Size: 6012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081207/fc862f6d/attachment.obj>