[llvm-commits] [llvm] r60484 - /llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp

Dan Gohman gohman at apple.com
Wed Dec 3 09:11:05 PST 2008


Author: djg
Date: Wed Dec  3 11:10:41 2008
New Revision: 60484

URL: http://llvm.org/viewvc/llvm-project?rev=60484&view=rev
Log:
Update a comment.

Modified:
    llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=60484&r1=60483&r2=60484&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp Wed Dec  3 11:10:41 2008
@@ -380,9 +380,10 @@
                                             SDValue &Base, SDValue &Offset){
   if (N.getOpcode() != ISD::ADD) {
     Base = N;
-    // We must materialize a zero in a reg! Returning an constant here won't
-    // work since its node is -1 so it won't get added to the selection queue.
-    // Explicitly issue a tMOVri8 node!
+    // We must materialize a zero in a reg! Returning a constant here
+    // wouldn't work without additional code to position the node within
+    // ISel's topological ordering in a place where ISel will process it
+    // normally.  Instead, just explicitly issue a tMOVri8 node!
     Offset = SDValue(CurDAG->getTargetNode(ARM::tMOVi8, MVT::i32,
                                     CurDAG->getTargetConstant(0, MVT::i32)), 0);
     return true;





More information about the llvm-commits mailing list