[llvm-commits] [patch] print ".file" directives
Dan Gohman
gohman at apple.com
Tue Dec 2 10:27:44 PST 2008
On Dec 2, 2008, at 2:52 AM, Rafael Espindola wrote:
>> How did I miss that!? In my new patch I added a hasDotFileDirective.
>> Will try with HasDotLocAndDotFile and post again.
>
> Attached. Tested on Linux X86-64 and darwin ppc.
The single-parameter .file is a completely different thing from the
two-parameter .file. Please use a separate flag rather than reusing
HasDotLocAndDotFile.
Also, in this line:
+ O << "\t.file \"" << M.getModuleIdentifier() << "\"\n";
please use a tab instead of a space after ".file" for consistency with
other directives.
Dan
More information about the llvm-commits
mailing list