[llvm-commits] Patch: small fix to bit convert and shifts

[Evan Cheng]

On Nov 30, 2008, at 8:32 PM, Mon Ping Wang wrote:

> Hi,
>
> This is a small patch that fixes two problems in SelectionDAG.cpp
>
>  1) in getShuffleScalarElt, the code assumes that if the input to  
> the shuffle is a BIT_CONVERT, the input to the bit convert is also a  
> vector.  This is not necessarily true as it is legal to bit convert a

You didn't finish your sentence? :-)

>
>
>  2) In getNode, the code assumes that for shifts, the shift amount  
> is always a scalar.  Since shifts can operate also on vectors, this  
> assumption is not correct.

The shift amount can be a vector as well? I thought operand 1 can be,  
but not the shift amount.

Evan

>
>
> -- Mon Ping
>
> <selection.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits