[llvm-commits] [llvm] r60352 - /llvm/trunk/include/llvm/ADT/STLExtras.h

[Chris Lattner]

Author: lattner
Date: Mon Dec  1 10:50:01 2008
New Revision: 60352

URL: http://llvm.org/viewvc/llvm-project?rev=60352&view=rev
Log:
define array_pod_sort in terms of operator< instead of my brain
damaged approximation.  This should fix it on big endian platforms
and on 64-bit.

Modified:
    llvm/trunk/include/llvm/ADT/STLExtras.h

Modified: llvm/trunk/include/llvm/ADT/STLExtras.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/STLExtras.h?rev=60352&r1=60351&r2=60352&view=diff

==============================================================================
--- llvm/trunk/include/llvm/ADT/STLExtras.h (original)
+++ llvm/trunk/include/llvm/ADT/STLExtras.h Mon Dec  1 10:50:01 2008
@@ -222,18 +222,14 @@
 }
 
 /// array_pod_sort_comparator - This is helper function for array_pod_sort,
-/// which does a memcmp of a specific size.
-template<unsigned Size>
+/// which just uses operator< on T.
+template<typename T>
 static inline int array_pod_sort_comparator(const void *P1, const void *P2) {
-  if (Size == sizeof(char))
-    return *(const char*)P1 - *(const char*)P2;
-  if (Size == sizeof(int))
-    return *(const int*)P1 - *(const int*)P2;
-  if (Size == sizeof(long long))
-    return *(const long long*)P1 - *(const long long*)P2;
-  if (Size == sizeof(intptr_t))
-    return *(intptr_t*)P1 - *(intptr_t*)P2;
-  return memcmp(P1, P2, Size);
+  if (*reinterpret_cast<const T*>(P1) < *reinterpret_cast<const T*>(P2))
+    return -1;
+  if (*reinterpret_cast<const T*>(P2) < *reinterpret_cast<const T*>(P1))
+    return 1;
+  return 0;
 }
 
 /// array_pod_sort - This sorts an array with the specified start and end
@@ -245,8 +241,8 @@
 /// possible.
 ///
 /// This function assumes that you have simple POD-like types that can be
-/// compared with memcmp and can be moved with memcpy.  If this isn't true, you
-/// should use std::sort.
+/// compared with operator< and can be moved with memcpy.  If this isn't true,
+/// you should use std::sort.
 ///
 /// NOTE: If qsort_r were portable, we could allow a custom comparator and
 /// default to std::less.