[llvm-commits] [llvm] r60343 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

[Bill Wendling]

Author: void
Date: Mon Dec  1 02:23:25 2008
New Revision: 60343

URL: http://llvm.org/viewvc/llvm-project?rev=60343&view=rev
Log:
Reduce copy-and-paste code by splitting out the code into its own function.

Modified:
    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=60343&r1=60342&r2=60343&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Mon Dec  1 02:23:25 2008
@@ -183,6 +183,8 @@
     Instruction *FoldAndOfICmps(Instruction &I, ICmpInst *LHS, ICmpInst *RHS);
     Instruction *visitAnd(BinaryOperator &I);
     Instruction *FoldOrOfICmps(Instruction &I, ICmpInst *LHS, ICmpInst *RHS);
+    Instruction *FoldOrWithConstants(BinaryOperator &I,
+                                     Value *A, Value *B, Value *C);
     Instruction *visitOr (BinaryOperator &I);
     Instruction *visitXor(BinaryOperator &I);
     Instruction *visitShl(BinaryOperator &I);
@@ -4445,6 +4447,50 @@
   return 0;
 }
 
+/// FoldOrWithConstants - This helper function folds:
+///
+///     ((A|B)&1)|(B&-2)
+///
+/// into:
+/// 
+///     (A&1) | B
+Instruction *InstCombiner::FoldOrWithConstants(BinaryOperator &I,
+                                               Value *A, Value *B, Value *C) {
+  Value *Op1 = I.getOperand(1);
+
+  if (ConstantInt *CI = dyn_cast<ConstantInt>(C)) {
+    if (CI->getValue() == 1) {
+      Value *V1 = 0, *C2 = 0;
+      if (match(Op1, m_And(m_Value(V1), m_Value(C2)))) {
+        ConstantInt *CI2 = dyn_cast<ConstantInt>(C2);
+
+        if (!CI2) {
+          std::swap(V1, C2);
+          CI2 = dyn_cast<ConstantInt>(C2);
+        }
+
+        if (CI2) {
+          APInt NegTwo = -APInt(CI2->getValue().getBitWidth(), 2, true);
+          if (CI2->getValue().eq(NegTwo)) {
+            if (V1 == B) {
+              Instruction *NewOp =
+                InsertNewInstBefore(BinaryOperator::CreateAnd(A, CI), I);
+              return BinaryOperator::CreateOr(NewOp, B);
+            }
+            if (V1 == A) {
+              Instruction *NewOp =
+                InsertNewInstBefore(BinaryOperator::CreateAnd(B, CI), I);
+              return BinaryOperator::CreateOr(NewOp, A);
+            }
+          }
+        }
+      }
+    }
+  }
+
+  return 0;
+}
+
 Instruction *InstCombiner::visitOr(BinaryOperator &I) {
   bool Changed = SimplifyCommutative(I);
   Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
@@ -4639,68 +4685,14 @@
   // ((A|B)&1)|(B&-2) -> (A&1) | B
   if (match(Op0, m_And(m_Or(m_Value(A), m_Value(B)), m_Value(C))) ||
       match(Op0, m_And(m_Value(C), m_Or(m_Value(A), m_Value(B))))) {
-    if (ConstantInt *CI = dyn_cast<ConstantInt>(C)) {
-      if (CI->getValue() == 1) {
-        Value *V1 = 0, *C2 = 0;
-        if (match(Op1, m_And(m_Value(V1), m_Value(C2)))) {
-          ConstantInt *CI2 = dyn_cast<ConstantInt>(C2);
-
-          if (!CI2) {
-            std::swap(V1, C2);
-            CI2 = dyn_cast<ConstantInt>(C2);
-          }
-
-          if (CI2) {
-            APInt NegTwo = -APInt(CI2->getValue().getBitWidth(), 2, true);
-            if (CI2->getValue().eq(NegTwo)) {
-              if (V1 == B) {
-                Instruction *NewOp =
-                  InsertNewInstBefore(BinaryOperator::CreateAnd(A, CI), I);
-                return BinaryOperator::CreateOr(NewOp, B);
-              }
-              if (V1 == A) {
-                Instruction *NewOp =
-                  InsertNewInstBefore(BinaryOperator::CreateAnd(B, CI), I);
-                return BinaryOperator::CreateOr(NewOp, A);
-              }
-            }
-          }
-        }
-      }
-    }
+    Instruction *Ret = FoldOrWithConstants(I, A, B, C);
+    if (Ret) return Ret;
   }
   // (B&-2)|((A|B)&1) -> (A&1) | B
   if (match(Op1, m_And(m_Or(m_Value(A), m_Value(B)), m_Value(C))) ||
       match(Op1, m_And(m_Value(C), m_Or(m_Value(A), m_Value(B))))) {
-    if (ConstantInt *CI = dyn_cast<ConstantInt>(C)) {
-      if (CI->getValue() == 1) {
-        Value *V1 = 0, *C2 = 0;
-        if (match(Op0, m_And(m_Value(V1), m_Value(C2)))) {
-          ConstantInt *CI2 = dyn_cast<ConstantInt>(C2);
-
-          if (!CI2) {
-            std::swap(V1, C2);
-            CI2 = dyn_cast<ConstantInt>(C2);
-          }
-
-          if (CI2) {
-            APInt NegTwo = -APInt(CI2->getValue().getBitWidth(), 2, true);
-            if (CI2->getValue().eq(NegTwo)) {
-              if (V1 == B) {
-                Instruction *NewOp =
-                  InsertNewInstBefore(BinaryOperator::CreateAnd(A, CI), I);
-                return BinaryOperator::CreateOr(NewOp, B);
-              }
-              if (V1 == A) {
-                Instruction *NewOp =
-                  InsertNewInstBefore(BinaryOperator::CreateAnd(B, CI), I);
-                return BinaryOperator::CreateOr(NewOp, A);
-              }
-            }
-          }
-        }
-      }
-    }
+    Instruction *Ret = FoldOrWithConstants(I, A, B, C);
+    if (Ret) return Ret;
   }
 
   if (match(Op0, m_Not(m_Value(A)))) {   // ~A | Op1