[llvm-commits] [llvm] r60306 - /llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

[Chris Lattner]

On Nov 30, 2008, at 1:09 PM, Eli Friedman wrote:

> Author: efriedma
> Date: Sun Nov 30 15:09:11 2008
> New Revision: 60306
>
> URL: http://llvm.org/viewvc/llvm-project?rev=60306&view=rev
> Log:
> Some minor cleanups to instcombine; no functionality change.

Hi Eli,

After hacking on instcombine a bit, I think what it really needs is a  
spiffy new kind of IRBuilder.  Before calling visit() on an  
instruction, the top level could set the builder to be positioned on  
the instruction (so any new instructions would default to going before  
it).  It could then use a template parameter to intercept the "insert"  
calls, implicitly adding the new instructions to the worklist in  
addition to inserting them into the program.

What do you think?

-Chris