[llvm-commits] [llvm] r60195 - /llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

[Chris Lattner]

Author: lattner
Date: Thu Nov 27 17:23:35 2008
New Revision: 60195

URL: http://llvm.org/viewvc/llvm-project?rev=60195&view=rev
Log:
Simplify LoopStrengthReduce::DeleteTriviallyDeadInstructions by
making it use RecursivelyDeleteTriviallyDeadInstructions to do
the heavy lifting.

Modified:
    llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp?rev=60195&r1=60194&r2=60195&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp Thu Nov 27 17:23:35 2008
@@ -240,31 +240,30 @@
 /// their operands subsequently dead.
 void LoopStrengthReduce::
 DeleteTriviallyDeadInstructions(SetVector<Instruction*> &Insts) {
+  SmallVector<Instruction*, 16> DeadInsts;
+  
   while (!Insts.empty()) {
     Instruction *I = Insts.back();
     Insts.pop_back();
+    
+    // If I is dead, delete it and all the things that it recursively uses
+    // that become dead.
+    RecursivelyDeleteTriviallyDeadInstructions(I, &DeadInsts);
+    
+    if (DeadInsts.empty()) continue;
+    Changed = true;
 
-    if (PHINode *PN = dyn_cast<PHINode>(I)) {
-      // If all incoming values to the Phi are the same, we can replace the Phi
-      // with that value.
-      if (Value *PNV = PN->hasConstantValue()) {
-        if (Instruction *U = dyn_cast<Instruction>(PNV))
-          Insts.insert(U);
-        SE->deleteValueFromRecords(PN);
-        PN->replaceAllUsesWith(PNV);
-        PN->eraseFromParent();
-        Changed = true;
-        continue;
-      }
-    }
-
-    if (isInstructionTriviallyDead(I)) {
-      for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i)
-        if (Instruction *U = dyn_cast<Instruction>(*i))
-          Insts.insert(U);
-      SE->deleteValueFromRecords(I);
-      I->eraseFromParent();
-      Changed = true;
+    while (!DeadInsts.empty()) {
+      Instruction *DeadInst = DeadInsts.back();
+      DeadInsts.pop_back();
+      
+      // Make sure ScalarEvolutions knows this instruction is gone.
+      SE->deleteValueFromRecords(DeadInst);
+      
+      // Make sure that this instruction is removed from DeadInsts if it was
+      // recursively removed.
+      if (DeadInst != I)
+        Insts.remove(DeadInst);
     }
   }
 }