[llvm-commits] [llvm] r59760 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Chris Lattner]

On Nov 20, 2008, at 4:11 PM, Bill Wendling wrote:
> Log:
> Add UADDO and SADDO nodes. These will be used for determining an  
> overflow
> condition in an addition operation.

Cool.

> @@ -249,7 +249,14 @@
> -
> +
> +    // Overflow-aware nodes for arithmetic operations. These nodes  
> take two
> +    // operands: the normal lhs and rhs to the add. They produce  
> two results:
> +    // the normal result of the add, and a flag indicating whether  
> an overflow
> +    // occured. These nodes are generated from the llvm. 
> [su]add.with.overflow
> +    // intrinsics. They are lowered by target-dependent code.
> +    SADDO, UADDO,

Please format the comment to make it more obvious what the input/ 
outputs are.  Here are some good examples to follow:

     // RESULT, OUTCHAIN = EXCEPTIONADDR(INCHAIN) - This node  
represents the
     // address of the exception block on entry to an landing pad block.
     EXCEPTIONADDR,

     // RESULT, OUTCHAIN = EHSELECTION(INCHAIN, EXCEPTION) - This node  
represents
     // the selection index of the exception thrown.
     EHSELECTION,

-Chris