[llvm-commits] [llvm] r58673 - in /llvm/trunk: include/llvm/CodeGen/Passes.h lib/CodeGen/LLVMTargetMachine.cpp lib/CodeGen/StackProtector.cpp

[Chris Lattner]

On Nov 17, 2008, at 9:33 PM, Bill Wendling wrote:
>> Some other comments:
>>
>> 1) are there any .ll testcases for the new intrinsics?  It seems  
>> that there should be something in test/CodeGen/X86.  Is there any  
>> target-specific code for the lowering?  If not, putting a test in  
>> test/CodeGen/generic would be even better.
>>
> There's no target-specific code for lowering. (YAY!) As far as  
> testcases, the only ones we have are in the llvm-gcc testsuite. But  
> I can craft together some kind of .ll files for our local tests.

Cool, just something simple is sufficient.

>> 2) does stackprotector_check need to be an intrinsic?  Can't it  
>> just be written in LLVM IR directly?
>>
> Hmm, perhaps. If the load is marked "volatile", will the optimizer  
> passes refrain from moving it around? That's the only question.  
> Right now the intrinsic is marked as "IntrReadMem", so I'm hoping  
> that passes will leave it alone.

IntrReadMem is the same as a non-volatile load.  A volatile load would  
be better.

>> Thanks again for working on this Bill!
>>
> No probs. :-)

Thanks Bil!

-Chris