[llvm-commits] [llvm] r59389 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/logical-select.ll

[Chris Lattner]

Author: lattner
Date: Sat Nov 15 22:25:26 2008
New Revision: 59389

URL: http://llvm.org/viewvc/llvm-project?rev=59389&view=rev
Log:
Handle the case where there is no "not".  It is possible it got 
folded into the select.

Modified:
    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
    llvm/trunk/test/Transforms/InstCombine/logical-select.ll

Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=59389&r1=59388&r2=59389&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Sat Nov 15 22:25:26 2008
@@ -4222,9 +4222,13 @@
   // Handle "cond ? -1 : 0".
   if (C1->isAllOnesValue() && C2->isZero()) {
     // ((cond?-1:0)&C) | (B&(cond?0:-1)) -> cond ? C : B.
+    if (match(D, SELECT_MATCH(Cond2, 0, -1)) && Cond2 == Cond)
+      return SelectInst::Create(Cond, C, B);
     if (match(D, m_Not(SELECT_MATCH(Cond2, -1, 0))) && Cond2 == Cond)
       return SelectInst::Create(Cond, C, B);
     // ((cond?-1:0)&C) | ((cond?0:-1)&D) -> cond ? C : D.
+    if (match(B, SELECT_MATCH(Cond2, 0, -1)) && Cond2 == Cond)
+      return SelectInst::Create(Cond, C, D);
     if (match(B, m_Not(SELECT_MATCH(Cond2, -1, 0))) && Cond2 == Cond)
       return SelectInst::Create(Cond, C, D);
   }

Modified: llvm/trunk/test/Transforms/InstCombine/logical-select.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/logical-select.ll?rev=59389&r1=59388&r2=59389&view=diff

==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/logical-select.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/logical-select.ll Sat Nov 15 22:25:26 2008
@@ -1,5 +1,5 @@
 ; RUN: llvm-as < %s | opt -instcombine | llvm-dis > %t
-; RUN: grep select %t | count 4
+; RUN: grep select %t | count 5
 ; RUN: not grep and %t
 ; RUN: not grep or %t
 
@@ -31,6 +31,17 @@
   %3 = or i32 %1, %2
   ret i32 %3
 }
+define i32 @poo(i32 %a, i32 %b, i32 %c, i32 %d) nounwind {
+entry:
+  %0 = icmp slt i32 %a, %b
+  %iftmp.0.0 = select i1 %0, i32 -1, i32 0
+  %1 = and i32 %iftmp.0.0, %c
+  %iftmp = select i1 %0, i32 0, i32 -1
+  %2 = and i32 %iftmp, %d
+  %3 = or i32 %1, %2
+  ret i32 %3
+}
+
 define i32 @par(i32 %a, i32 %b, i32 %c, i32 %d) nounwind {
 entry:
   %0 = icmp slt i32 %a, %b