[llvm-commits] Patch: split vector shuffle in LegalizeType

[Mon Ping Wang]

Hi Duncan,

You are correct that I'm doing the same thing twice but with different  
indexes.  I didn't like DeterVectorShuffleUses because of the number  
of parameters it took and the interesting side effect it had so I took  
your advice and inlined it.  For now, I left it assuming LoVT and HiVT  
after the split may be different.  Functionality,  I left it pretty  
much alone and left the other helper function alone.  If anyone has  
any comments, please let me know and thanks for the review.

-- Mon Ping

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shuffle3.patch
Type: application/octet-stream
Size: 10994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20081111/de343a73/attachment.obj>
-------------- next part --------------



On Nov 7, 2008, at 12:07 PM, Duncan Sands wrote:

> Hi Mon Ping, I can't help feeling that rather than repeating almost
> the same code twice, you could use a loop instead.  Then you can
> "inline" DeterVectorShuffleUse, which as far as I can see can lead
> to additional simplifications (it also seems to be written in a kind
> of complicated way).  In fact, you can determine which lo/hi parts
> to use on the fly as you work your way down the mask, building the
> new mask vector as you go, rather than prescanning the mask, then
> building the new mask vector afterwards.  Just some thoughts.
>
> Ciao,
>
> Duncan.