[llvm-commits] [llvm] r58995 - in /llvm/trunk: lib/Transforms/Scalar/LoopIndexSplit.cpp test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll

[Devang Patel]

Author: dpatel
Date: Mon Nov 10 13:48:34 2008
New Revision: 58995

URL: http://llvm.org/viewvc/llvm-project?rev=58995&view=rev
Log:
If the sign of exit condition and split condition does not match
then do not split loop index.

Added:
    llvm/trunk/test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/LoopIndexSplit.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/LoopIndexSplit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopIndexSplit.cpp?rev=58995&r1=58994&r2=58995&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopIndexSplit.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopIndexSplit.cpp Mon Nov 10 13:48:34 2008
@@ -1437,7 +1437,12 @@
     if (ICMP->getPredicate() == ICmpInst::ICMP_EQ)
       return false;
   }
-  
+
+  // If the predicate sign does not match then skip.
+  ICmpInst *CI = dyn_cast<ICmpInst>(SD.SplitCondition);
+  if (CI && (ExitCondition->isSignedPredicate() != CI->isSignedPredicate()))
+    return false;
+
   BasicBlock *SplitCondBlock = SD.SplitCondition->getParent();
   
   // Unable to handle triangle loops at the moment.

Added: llvm/trunk/test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll?rev=58995&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll (added)
+++ llvm/trunk/test/Transforms/LoopIndexSplit/2008-11-10-Sign.ll Mon Nov 10 13:48:34 2008
@@ -0,0 +1,69 @@
+; RUN: llvm-as < %s | opt -loop-index-split -stats | not grep "loop-index-split"
+; PR3029
+
+ at g_138 = common global i32 0		; <i32*> [#uses=3]
+ at g_188 = common global i32 0		; <i32*> [#uses=4]
+ at g_207 = common global i32 0		; <i32*> [#uses=3]
+@"\01LC" = internal constant [4 x i8] c"%d\0A\00"		; <[4 x i8]*> [#uses=1]
+ at g_102 = common global i32 0		; <i32*> [#uses=0]
+
+define i32 @func_119() nounwind {
+entry:
+	%0 = volatile load i32* @g_138, align 4		; <i32> [#uses=1]
+	ret i32 %0
+}
+
+define void @func_110(i32 %p_111) nounwind {
+entry:
+	%0 = load i32* @g_188, align 4		; <i32> [#uses=1]
+	%1 = icmp ugt i32 %0, -1572397472		; <i1> [#uses=1]
+	br i1 %1, label %bb, label %bb1
+
+bb:		; preds = %entry
+	%2 = volatile load i32* @g_138, align 4		; <i32> [#uses=0]
+	ret void
+
+bb1:		; preds = %entry
+	store i32 1, i32* @g_207, align 4
+	ret void
+}
+
+define void @func_34() nounwind {
+entry:
+	store i32 0, i32* @g_188
+	%g_188.promoted = load i32* @g_188		; <i32> [#uses=1]
+	br label %bb
+
+bb:		; preds = %func_110.exit, %entry
+	%g_188.tmp.0 = phi i32 [ %g_188.promoted, %entry ], [ %2, %func_110.exit ]		; <i32> [#uses=2]
+	%0 = icmp ugt i32 %g_188.tmp.0, -1572397472		; <i1> [#uses=1]
+	br i1 %0, label %bb.i, label %bb1.i
+
+bb.i:		; preds = %bb
+	%1 = volatile load i32* @g_138, align 4		; <i32> [#uses=0]
+	br label %func_110.exit
+
+bb1.i:		; preds = %bb
+	store i32 1, i32* @g_207, align 4
+	br label %func_110.exit
+
+func_110.exit:		; preds = %bb.i, %bb1.i
+	%2 = add i32 %g_188.tmp.0, 1		; <i32> [#uses=3]
+	%3 = icmp sgt i32 %2, 1		; <i1> [#uses=1]
+	br i1 %3, label %return, label %bb
+
+return:		; preds = %func_110.exit
+	%.lcssa = phi i32 [ %2, %func_110.exit ]		; <i32> [#uses=1]
+	store i32 %.lcssa, i32* @g_188
+	ret void
+}
+
+define i32 @main() nounwind {
+entry:
+	call void @func_34() nounwind
+	%0 = load i32* @g_207, align 4		; <i32> [#uses=1]
+	%1 = call i32 (i8*, ...)* @printf(i8* getelementptr ([4 x i8]* @"\01LC", i32 0, i32 0), i32 %0) nounwind		; <i32> [#uses=0]
+	ret i32 0
+}
+
+declare i32 @printf(i8*, ...) nounwind