[llvm-commits] [llvm] r58791 - in /llvm/trunk: include/llvm/CodeGen/MachineFrameInfo.h include/llvm/Intrinsics.td lib/CodeGen/PrologEpilogInserter.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp lib/CodeGen/StackProtector.cpp

[Bill Wendling]

On Nov 5, 2008, at 10:12 PM, Evan Cheng wrote:

> On Nov 5, 2008, at 6:29 PM, Bill Wendling wrote:
>
>> +  /// HasStackProtector - Set to true if this function has stack
>> protectors.
>> +  bool HasStackProtector;
>
> There is no need for HasStackProtector. If StackProtectorIndex is
> negative (fixed object), then the MF doesn't have one.
>
Okay.

>> +// Stack protector intrinsics.
>> +def int_stackprotector_prologue : Intrinsic<[llvm_void_ty,
>> llvm_ptr_ty]>;
>> +def int_stackprotector_epilogue : Intrinsic<[llvm_ptr_ty]>;
>
> Comments? How are these used? Do they read / write memory?
>
Modified.

>> +  case Intrinsic::stackprotector_prologue: {
>
> Ok. Perhaps call this stackprotector_create? And change
> stackprotector_epilogue to stackprotector_check?
>
Ick! but okay.

-bw