[llvm-commits] Patch: improve protability of llvm-config

Kenneth Boyd zaimoni at zaimoni.com
Wed Nov 5 11:00:36 PST 2008


Sascha Othman wrote:
> May I then suggest the following changes in response to Julien's message
> at
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20081103/069380.html
> ?
> His proposed patch works as far as I can tell (thanks, Julien), but it
> has the sideeffect of not resolving to absolute paths and thus making
> llvm-config produce output like /usr/local/bin/../bin
> The submitted solution here was tested on linux, MSYS/MinGW and Windows.
>   
Weird.  I think the point is that realpath/abs_path is broken under 
mingw Perl (it is what I use to make ActiveState work.)

So a proper patch *needs* to fall back to Cwd::realpath/abs_path when 
shell scripting fails outright, rather than failover to shell scripting 
when Cwd doesn't load (which as a base module it should for Perl 5.6.0 
and later).

Kenneth




More information about the llvm-commits mailing list