[llvm-commits] [llvm] r58673 - in /llvm/trunk: include/llvm/CodeGen/Passes.h lib/CodeGen/LLVMTargetMachine.cpp lib/CodeGen/StackProtector.cpp

[Bill Wendling]

Hi Anton,

>> We looked at the code in code gen -- the lowering of allocas. It's
>> doing the "right thing" with regard to this. There might be some
>> special magic that needs to be done, though.
>
> Just quick q: I think this will work without any problems on targets,
> which require stack probing (and this alloca is lowered to special
> call), right?
>
It shouldn't mess up that code. The only requirement is that the
canary be shoved into the "correct" place on the stack to catch any
stack smashing activities. I suppose it's possible that it won't work
as expected in such a case. It's clear that this part needs some more
attention.

-bw