[llvm-commits] [PATCH] catch user error in Pass.h

Devang Patel dpatel at apple.com
Fri Oct 31 10:23:52 PDT 2008


On Oct 31, 2008, at 10:16 AM, Török Edwin wrote:

> Hi,
>
> The attached patch adds an assert to Pass.h to prevent mistakes like
> this which successfully compiles&links:
>
> MyFunctionPass() : FunctionPass(ID) {}
>
> instead of
>
> MyFunctionPass() : FunctionPass(&ID) {}
>
>
> OK to commit?

ok. Watch out for 80 cols limit.

>
>
> Best regards,
> --Edwin
>
> <pass.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-
Devang







More information about the llvm-commits mailing list