[llvm-commits] [llvm] r58411 - /llvm/trunk/include/llvm/Support/DataTypes.h.in

[Dan Gohman]

On Oct 29, 2008, at 5:48 PM, Bill Wendling wrote:

> On Wed, Oct 29, 2008 at 5:36 PM, Dan Gohman <gohman at apple.com> wrote:
>>
>> On Oct 29, 2008, at 5:11 PM, Bill Wendling wrote:
>>
>>>
>>> -#if !defined(__STDC_CONSTANT_MACROS)
>>> -# error "Must #define __STDC_CONSTANT_MACROS before " \
>>> -        "#including Support/DataTypes.h"
>>> -#endif
>>
>> This code was meant to be similar to the code a few lines up.
>
> Yeah, I caught that.
>
>> Where is __STDC_LIMIT_MACROS defined in the SnowLeopard build?
>> __STDC_CONSTANT_MACROS should be defined there too.
>>
> They're both #defined in c++/4.2.1/tr1/cstdint, but I don't think that
> that file is being pulled in (otherwise, we wouldn't get the error).
> They're also defined in several PCHs. I'm not sure what's happening
> here.

The normal place for __STDC_LIMIT_MACROS to be defined is in
LLVM's own Makefile.rules or CMakeLists.txt.  __STDC_CONSTANT_MACROS
is now also defined in both of those.

Dan