[llvm-commits] [llvm] r58336 - /llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h

[Chris Lattner]

On Oct 28, 2008, at 10:23 AM, Evan Cheng wrote:

> Author: evancheng
> Date: Tue Oct 28 12:23:13 2008
> New Revision: 58336
>
> URL: http://llvm.org/viewvc/llvm-project?rev=58336&view=rev
> Log:
> Avoid calls to setSubgraphColor in release mode. They generate lots  
> of error messages and slow down compilation.

Do we even want this in debug mode?  Why not make this predicated on  
whether -view-isel-dags is set?

-Chris

>
>
> Modified:
>    llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
>
> Modified: llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h?rev=58336&r1=58335&r2=58336&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h (original)
> +++ llvm/trunk/include/llvm/CodeGen/DAGISelHeader.h Tue Oct 28  
> 12:23:13 2008
> @@ -176,7 +176,9 @@
>     // Skip already selected nodes.
>     if (isSelected(Node->getNodeId()))
>       continue;
> +#ifndef NDEBUG
>     DAG.setSubgraphColor(Node, "red");
> +#endif
>     SDNode *ResNode = Select(SDValue(Node, 0));
>     // If node should not be replaced,
>     // continue with the next one.
> @@ -184,8 +186,10 @@
>       continue;
>     // Replace node.
>     if (ResNode) {
> +#ifndef NDEBUG
>       DAG.setSubgraphColor(ResNode, "yellow");
>       DAG.setSubgraphColor(ResNode, "black");
> +#endif
>       ReplaceUses(Node, ResNode);
>     }
>     // If after the replacement this node is not used any more,
> @@ -195,7 +199,6 @@
>       CurDAG->RemoveDeadNode(Node, &ISQU);
>       UpdateQueue(ISQU);
>     }
> -    //DAG.setSubgraphColor(Node, "black");
>   }
>
>   delete[] ISelQueued;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits