[llvm-commits] [llvm] r58290 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp

Ted Kremenek kremenek at apple.com
Mon Oct 27 15:43:07 PDT 2008


Author: kremenek
Date: Mon Oct 27 17:43:07 2008
New Revision: 58290

URL: http://llvm.org/viewvc/llvm-project?rev=58290&view=rev
Log:
Fix bogus comparison of "const char *" with c-string literal.  Use strcmp instead.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp?rev=58290&r1=58289&r2=58290&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp Mon Oct 27 17:43:07 2008
@@ -369,10 +369,10 @@
   bool printed = false;
   if (setSubgraphColorHelper(N, Color, visited, 0, printed)) {
     // Visually mark that we hit the limit
-    if (Color == "red" ) {
+    if (strcmp(Color, "red") == 0) {
       setSubgraphColorHelper(N, "blue", visited, 0, printed);
     }
-    else if (Color == "yellow" ) {
+    else if (strcmp(Color, "yellow") == 0) {
       setSubgraphColorHelper(N, "green", visited, 0, printed);
     }
   }





More information about the llvm-commits mailing list