[llvm-commits] [llvm-gcc-4.2] r53079 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Chris Lattner]

On Jul 3, 2008, at 2:35 AM, Duncan Sands wrote:

> Hi Chris,
>
>> +/// LocalLLVMValueIDs - This is the set of local IDs we have in  
>> our mapping,
>> +/// this allows us to efficiently identify and remove them.
>
> how about adding an explanation of what a local value is?
>
>> +    if (Value *V = LLVMValues[Idx]) {
>> +      assert(!isa<Constant>(V) && "Found local value");
>
> Shouldn't this be "Found global value!"?

Yep, fixed thanks!

-Chris