[llvm-commits] [llvm] r58199 - /llvm/trunk/lib/Support/raw_ostream.cpp

[Chris Lattner]

On Oct 26, 2008, at 1:29 PM, Chris Lattner wrote:

>
> On Oct 26, 2008, at 1:19 PM, Török Edwin wrote:
>
>> On 2008-10-26 21:20, Chris Lattner wrote:
>>> Author: lattner
>>> Date: Sun Oct 26 14:20:47 2008
>>> New Revision: 58199
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=58199&view=rev
>>> Log:
>>> fix PR2953, an off-by-one error handling formatted i/o.
>>> Thanks to Török Edwin for the awesome reduced testcase.
>>>
>>
>> I think that this fix should be pulled into 2.4.
>> Who knows when it might trigger, there  is lots of code using
>> raw_ostream...
>
> This can only happen when formatters are used.  I think these are
> currently only used by Clang, so no bug could manifest in 2.4,

Actually, on further consideration, I agree with Edwin.  People with  
external code could run into this bug, and fixing it has no risk.   
Tanya, please pull this patch into 2.4, thanks!
http://llvm.org/viewvc/llvm-project?rev=58199&view=rev

-Chris