[llvm-commits] [llvm] r57846 - in /llvm/trunk: include/llvm/System/Memory.h lib/System/Unix/Memory.inc lib/System/Win32/Memory.inc lib/Target/ARM/ARMJITInfo.cpp

[Duncan Sands]

> Added back in range-based memory permission functions for the updating of
> the stub on Darwin.

Is this really Darwin specific?

Also, there doesn't seem to be any need for the #if defined(__APPLE__)
in these kinds of places:

+#if defined(__APPLE__)
+  ok = sys::Memory::setRangeExecutable ((void*)StubAddr, 8);
+  if (!ok)
+    {
+      cerr << "ERROR: Unable to mark stub executable\n";
+      abort();
+    }
+#endif

After all, the functions complete successfully on non-__APPLE__
platforms.

Ciao,

Duncan.