[llvm-commits] [llvm] r57786 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Dan Gohman]

On Sun, October 19, 2008 1:51 pm, Bill Wendling wrote:
> Author: void
> Date: Sun Oct 19 15:51:12 2008
> New Revision: 57786
>
> URL: http://llvm.org/viewvc/llvm-project?rev=57786&view=rev
> Log:
> Set N->OperandList to 0 after deletion. Otherwise, it's possible that it
> will
> be either deleted or referenced afterwards.

Hi Bill,

Is this addressing an actual bug?  Both of the changes are
modifying fields of objects immediately before they are
deallocated, so if there is code somewhere else that is using
uninitialized SDNode fields, we should fix that code,
regardless of this change.

Thanks,

Dan