[llvm-commits] Patch for handling multiple values in ExpandIntegerOperand

[sanjiv gupta]

On Sun, 2008-10-19 at 17:45 +0200, Duncan Sands wrote:
> Hi,
> 
> > What's the best way to find out all places that need fixing up?
> 
> I think code inspection is the only way.
> 
> > Should I just look into the Expand* functions in all targets and find
> > out what needs to use MergeValues?
> 
> Yes.  I can give you a hand with this, but not this week.
> 
That would be a great help. Meanwhile I will make a patch to take of
LegalizeIntegerTypes.cpp. I think there might be other places in the
same file where we need to use ReplaceNodeWith.

> > Or should I just make this change in
> > ExpandIntegerOperand() and let target owners take care of it. What all
> > targets are currently using -enable-legalize-types? I guess only X86.
> 
> LegalizeTypes is not for any particular target.  Today it is not turned
> on by default, but I hope to change that by the end of the week.
> 
I asked this because only the targets that currently  depend upon or
work with -enable-legalize-types may need  fixing up with MergeValues.

-Sanjiv

> Ciao,
> 
> Duncan.