[llvm-commits] Patch for handling multiple values in ExpandIntegerOperand

sanjiv gupta sanjiv.gupta at microchip.com
Sat Oct 18 10:29:18 PDT 2008


On Sat, 2008-10-18 at 18:23 +0200, Duncan Sands wrote:
> Hi,
> 
> -  assert(Res.getValueType() == N->getValueType(0) && N->getNumValues() == 1 &&
> -         "Invalid operand expansion");
> +  // The result node should return same or more values as the original node.
> +  assert (Res.getNode()->getNumValues() >= N->getNumValues());
> 
> I'd rather use ReplaceAllUsesWith and require the number
> of values to be the same.  This is more work of course,
> since it means fixing up several places.
> 
> Ciao,
> 
> Duncan.

Please refer to one of your posts to see why number of values can't be
same.

http://lists.cs.uiuc.edu/pipermail/llvmdev/2008-September/016767.html

- Sanjiv



More information about the llvm-commits mailing list