[llvm-commits] [llvm] r57641 - in /llvm/trunk: include/llvm/Use.h lib/VMCore/Use.cpp

[Chris Lattner]

On Oct 17, 2008, at 1:42 AM, Gabor Greif wrote:
>>> Notably this approach does not catch dereferencing of tagged
>>> pointers, but helps
>>> in separating the two concepts a bit.
>>
>> Gabor, this is very interesting, but it is very subtle and definitely
>> needs some comments in the code.  Please add them.
>
> Hmmm, I am specialized on subtle things :-)
> I was so happy yesterday that this scheme worked out with minimal
> changes that I have completely forgotten documenting it. I have just
> added some lines, but I am not sure how these can find their way into
> doxygen. Anybody?

Thanks Gabor, I'm not too concerned about doxygenating the comments,  
but if someone wanted to figure that out, it would be fine.

On another topic, in Clang we usually represent type tagged pointers  
as intptr_t members instead of foo*'s.  The accessor that extracts the  
pointer from the intptr_t just does a cast to foo* after masking out  
the bits.  Would this be better than using volatile?

-Chris