[llvm-commits] [llvm] r57413 - /llvm/trunk/lib/Analysis/EscapeAnalysis.cpp

[Duncan Sands]

Hi Owen,

> Add special-case code to allow null-guards on calls to malloc.

how about adding some comments describing all the evil situations
you are dealing with?  For example, here it would be tempting to
use getUnderlyingObject rather than stripPointerCasts, yet that
would be wrong.  Explaining why will help later when we've all
forgotten why things were done this way :)

Ciao,

Duncan.