[llvm-commits] [poolalloc] r57214 - /poolalloc/trunk/lib/PoolAllocate/TransformFunctionBody.cpp

[Duncan Sands]

> > Thanks, the tail call markings I was still looking into. The parameter
> > attributes are handled during the function clone/rewriting (but suffer
> > from potential off by one errors, parameter attributes should really
> > be properties of the Argument class rather than positional in the
> > Function class).
> 
> Actually, it's not clear, does one have to specify parameter
> attributes on the call site too?  I was under the impression they just
> were for the functions.  hmm...

Yes, you should.  This is needed for indirect calls, also
in some situations stronger information is available on
the call than on the function.

Ciao,

Duncan.

PS: I agree that parameter attributes are currently a pain to
work with - it would be simpler if they were somehow attached
to the Argument class.