[llvm-commits] [patch] Fix LegalizeDAG to convert ISD::MUL to libcall is MUL operation is not found.

Mikael Lepistö mikael.lepisto at tut.fi
Sat Oct 4 16:51:38 PDT 2008


Works like a charm, thanks a lot!

-mikael

On 5.10.2008, at 0:28, Chris Lattner wrote:

>
> On Oct 4, 2008, at 2:01 PM, Mikael Lepistö wrote:
>
>> Yes, I ran the tests (ran them again just before writing this  
>> reply). Before patch legalize dag pass just crashed if there was  
>> not any mul operations. So I thought that it would be ok to emit  
>> libcall in place where it's found out that we really don't have the  
>> operation.
>
> Aha, I see that you're right.  Sorry for doubting you!  I applied  
> this patch, please verify that it fixes the problem you're seeing,  
> thanks!
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080929/068061.html
>
> -Chris
>
>>
>>
>> -mikael
>>
>> 		===  Summary ===
>>
>> # of expected passes		2769
>> # of expected failures		6
>>
>> On 4.10.2008, at 23:27, Chris Lattner wrote:
>>
>>>
>>> On Oct 3, 2008, at 1:37 AM, Mikael Lepistö wrote:
>>>
>>>> Hi,
>>>>
>>>> I tried to compile stuff without mul operation in target and  
>>>> LegalizeDAG failed when it tried to expand ISD::MUL. This patch  
>>>> seemed to help.
>>>
>>> Have you run dejagnu tests with this patch applied?  It appears  
>>> that it would disable all the mulhs/mulhu optimizations below it.
>>>
>>> -Chris
>>
>





More information about the llvm-commits mailing list