[llvm-commits] [llvm] r56930 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

[Chris Lattner]

On Oct 1, 2008, at 1:39 PM, Dan Gohman wrote:

> Author: djg
> Date: Wed Oct  1 15:39:19 2008
> New Revision: 56930
>
> URL: http://llvm.org/viewvc/llvm-project?rev=56930&view=rev
> Log:
> Enable FastISel by default (on x86 and x86-64) with the -fast option.

Very cool!

> +// Enable or disable FastISel. Both options are needed, because
> +// FastISel is enabled by default with -fast, and we wish to be
> +// able to enable or disable fast-isel independently from -fast.
> +static cl::opt<bool>
> +EnableFastISelOption("fast-isel", cl::Hidden,
> +  cl::desc("Enable the experimental \"fast\" instruction selector"));
> +static cl::opt<bool>
> +DisableFastISelOption("disable-fast-isel", cl::Hidden,
> +  cl::desc("Disable the experimental \"fast\" instruction  
> selector"));

This seems like it should be a tri-state/enum option, not two  
different and mutually conflicting options.

-Chris